Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkgcfg and warn #3

Closed
wants to merge 4 commits into from
Closed

Pkgcfg and warn #3

wants to merge 4 commits into from

Conversation

gwr
Copy link
Member

@gwr gwr commented Dec 31, 2016

Cleanup the two problems discussed on-list last week.

tsoome
tsoome reviewed Jan 3, 2017
View reviewed changes
Copy link

@tsoome tsoome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about pkgconfig, sorry..

tsoome
tsoome approved these changes Jan 3, 2017
View reviewed changes
Copy link

@tsoome tsoome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me

@gwr
Copy link
Member Author

gwr commented Jan 3, 2017

BTW, the pkgconfig files are the same before and after this change.
I'm just combining the two patches, because it's very difficult to
maintain patches when more than one patch touches a given file.

@gwr gwr closed this Jan 4, 2017
hoewweken added a commit to hoewweken/gfx-drm that referenced this pull request Mar 19, 2019
@hoewweken
libdrm 2.4.83 refine Makefile.drm illumos#3
15a697d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsoome tsoome tsoome approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gwr @tsoome