Skip to content

Commit

Permalink
12566 seeprom: NULL pointer errors
Browse files Browse the repository at this point in the history
Reviewed by: Robert Mustacchi <rm@fingolfin.org>
Reviewed by: Yuri Pankov <ypankov@tintri.com>
Approved by: Dan McDonald <danmcd@joyent.com>
  • Loading branch information
tsoome committed Jun 5, 2020
1 parent 6523a3a commit 6b9ce6a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 21 deletions.
2 changes: 1 addition & 1 deletion usr/src/uts/sun4u/io/i2c/clients/seeprom.c
Expand Up @@ -167,7 +167,7 @@ seeprom_do_attach(dev_info_t *dip)
"%s%d", ddi_driver_name(dip), instance);

if (ddi_create_minor_node(dip, ddi_node_name(dip), S_IFCHR,
instance, SEEPROM_NODE_TYPE, NULL) == DDI_FAILURE) {
instance, SEEPROM_NODE_TYPE, 0) == DDI_FAILURE) {
cmn_err(CE_WARN, "%s ddi_create_minor_node failed for '%s'",
unitp->seeprom_name, ddi_node_name(dip));
ddi_soft_state_free(seepromsoft_statep, instance);
Expand Down
20 changes: 0 additions & 20 deletions usr/src/uts/sun4u/seeprom/Makefile
Expand Up @@ -35,35 +35,21 @@ UTSBASE = ../..
#
MODULE = seeprom
OBJECTS = $(SEEPROM_OBJS:%=$(OBJS_DIR)/%)
LINTS = $(SEEPROM_OBJS:%.o=$(LINTS_DIR)/%.ln)
ROOTMODULE = $(ROOT_PSM_DRV_DIR)/$(MODULE)

#
# Include common rules.
#
include $(UTSBASE)/sun4u/Makefile.sun4u

#
# lint pass one enforcement
#
CFLAGS += $(CCVERBOSE)

LDFLAGS += -dy -N misc/i2c_svc

#
# For now, disable these lint checks; maintainers should endeavor
# to investigate and remove these for maximum lint coverage.
# Please do not carry these forward to new Makefiles.
#
LINTTAGS += -erroff=E_SUPPRESSION_DIRECTIVE_UNUSED

CERRWARN += $(CNOWARN_UNINIT)

#
# Define targets
#
ALL_TARGET = $(BINARY)
LINT_TARGET = $(MODULE).lint
INSTALL_TARGET = $(BINARY) $(ROOTMODULE)

.KEEP_STATE:
Expand All @@ -76,12 +62,6 @@ clean: $(CLEAN_DEPS)

clobber: $(CLOBBER_DEPS)

lint: $(LINT_DEPS)

modlintlib: $(MODLINTLIB_DEPS)

clean.lint: $(CLEAN_LINT_DEPS)

install: $(INSTALL_DEPS)

#
Expand Down

0 comments on commit 6b9ce6a

Please sign in to comment.