13989 libproc can leak core CTF data

Reviewed by: Andy Fiddaman <andy@omnios.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>
illumos · Aug 17, 2021 · 9148a91 · 9148a91
1 parent 50d4d24
commit 9148a91
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/usr/src/lib/libproc/common/Psymtab.c b/usr/src/lib/libproc/common/Psymtab.c
@@ -298,10 +298,8 @@ file_info_free(struct ps_prochandle *P, file_info_t *fptr)
 			(void) elf_end(fptr->file_dbgelf);
 		if (fptr->file_dbgfile >= 0)
 			(void) close(fptr->file_dbgfile);
-		if (fptr->file_ctfp) {
-			ctf_close(fptr->file_ctfp);
-			free(fptr->file_ctf_buf);
-		}
+		ctf_close(fptr->file_ctfp);
+		free(fptr->file_ctf_buf);
 		if (fptr->file_saddrs)
 			free(fptr->file_saddrs);
 		free(fptr);