Skip to content

Commit

Permalink
6639 uhci_qh walker contains whacky boolean logic
Browse files Browse the repository at this point in the history
Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
Approved by: Robert Mustacchi <rm@joyent.com>
  • Loading branch information
richlowe committed Feb 13, 2016
1 parent 1665390 commit a7317ce
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions usr/src/cmd/mdb/common/modules/uhci/uhci.c
Expand Up @@ -24,8 +24,6 @@
* Use is subject to license terms.
*/

#pragma ident "%Z%%M% %I% %E% SMI"

#include <gelf.h>

#include <sys/mdb_modapi.h>
Expand Down Expand Up @@ -485,7 +483,7 @@ uhci_td_walk_step(mdb_walk_state_t *wsp)


if (mdb_vread(wsp->walk_data, sizeof (uhci_td_t), wsp->walk_addr)
== -1) {
== -1) {
mdb_warn("failed to read td at %p", wsp->walk_addr);
return (WALK_DONE);
}
Expand Down Expand Up @@ -584,8 +582,8 @@ uhci_qh_walk_step(mdb_walk_state_t *wsp)
}

/* Make sure next element is a QH. If a TD, stop. */
if (! ((((queue_head_t *)wsp->walk_data)->link_ptr) & HC_QUEUE_HEAD)
== HC_QUEUE_HEAD) {
if (((((queue_head_t *)wsp->walk_data)->link_ptr) & HC_QUEUE_HEAD)
!= HC_QUEUE_HEAD) {
return (WALK_DONE);
}

Expand Down

0 comments on commit a7317ce

Please sign in to comment.