Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font and image size. #10

Open
birkanozer opened this issue Jan 12, 2023 · 3 comments
Open

Font and image size. #10

birkanozer opened this issue Jan 12, 2023 · 3 comments
Labels
frontend Frontend issue or improvement

Comments

@birkanozer
Copy link

Hi there,
I can see that you put great effort into this library. Since you try to pack a lot of info into a bit of space, things get really condensed. As a new learner, I find it very confusing. Also, the font and style that you use give a good sense of humour yet a small font size is hard to read.

My suggestion is to make it a more vertical design with bigger fonts and images. It will make it easier to read and understand.

Thanks

@francescodisalvo05
Copy link
Member

Hi! 👋🏻

Thank you for your feedback, appreciate it! I agree that the font may be "difficult" to read for someone, in fact, we are also working on a button for switching between a normal font and this sketchy one.

However, regarding the font size, we were confident it was not a problem because it is an SVG and it is possible to zoom without loss of quality. I am not sure that rearranging all the illustrations will be feasible for time constraints, but we'll bear this in mind for the next illustrations though!

I'll close the issue when this font-style switch will be available :D

@berna1995
Copy link
Collaborator

@francescodisalvo05

I created a branch to work on this issue and I added a commit with a javascript function to switch the font-family of all the texts inside the SVGs. See 0bd850d.

We just need some front-end UI support to make the "toggle" between "normal" font and the "sketchy" one.

@francescodisalvo05
Copy link
Member

Thank you @berna1995 , that's a first starting point!

@bozzelliandrea bozzelliandrea added the frontend Frontend issue or improvement label Feb 2, 2023
@bozzelliandrea bozzelliandrea changed the title Frontend - Font and image size. Font and image size. Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend issue or improvement
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants