Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/better types #1

Merged
merged 2 commits into from
Feb 4, 2021
Merged

feature/better types #1

merged 2 commits into from
Feb 4, 2021

Conversation

will-wow
Copy link
Collaborator

@will-wow will-wow commented Feb 4, 2021

Goal

Add typing for events, systems, multiple, and the rest of the component properties

Solution

  • Add static type for multiple
  • Copy over all types from AFRAME.Component
  • Make toComponent have better type inference and returns
  • Add sample test code for the SampleComponent

@will-wow will-wow merged commit 77c479c into main Feb 4, 2021
@will-wow will-wow deleted the feature/better-types branch February 4, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant