Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Commit

Permalink
feat: add API to get latest outages
Browse files Browse the repository at this point in the history
  • Loading branch information
thomas-barthelemy authored and Thomas Barthelemy committed Aug 29, 2016
1 parent 3a0e95e commit 692bc23
Show file tree
Hide file tree
Showing 3 changed files with 161 additions and 0 deletions.
50 changes: 50 additions & 0 deletions lib/storage/providers/redis.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,56 @@ StorageRedis.prototype.getServiceOutagesSince = function (service, timestamp, ca
});
};

/**
* Get outage history for all services
* @param services
* @param options
* @param callback
*/

StorageRedis.prototype.getServicesOutagesSince = function (services, options, callback) {
// Creating a multi request to get each service outages.
var multi = this.redis.multi();
for (var i = 0; i < services.length; i++) {
multi.zrevrangebyscore(
services[i].id + ':' + OUTAGES_KEY_SUFIX,
'+inf',
options.since,
'LIMIT',
0,
options.maxItemsPerService
);
}

multi.exec(function (err, replies) {
if (err) {
return callback(err, null);
}

var servicesOutages = [];
for (var i = 0; i < services.length; i++) {
var svcOutages = replies[i].map(function (outage) {
outage = JSON.parse(outage);
outage['service'] = services[i].id;
return outage;
});

servicesOutages = servicesOutages.concat(svcOutages);
}

// Sorting by timestamp
servicesOutages.sort(function (a, b) {
if(a.timestamp < b.timestamp)
return -1;
if(a.timestamp < b.timestamp)
return 1;
return 0;
});

callback(null, servicesOutages.slice(0, options.maxItems));
})
};

/**
* Records ping latency
* @param service
Expand Down
83 changes: 83 additions & 0 deletions test/test-api-report-route.js
Original file line number Diff line number Diff line change
Expand Up @@ -306,4 +306,87 @@ describe('report route', function () {
});
});

describe('loading all outages', function () {

describe('with an anonymous user', function () {
before(function (done) {
agent.get('/logout').expect(302, done);
});

it('should not require auth', function (done) {
storage.addService(validService, function (err, id) {
assert.ifError(err);
agent
.get(API_ROOT + '/services/outages')
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200)
.send()
.end(function (err, res) {
// Todo: Load some outages and check
done(err);
});
});
});
});

describe('with an authenticated normal user', function () {
before(function (done) {
agent.get('/login/test/2').expect(200, done);
});

it('should have not access if restrictions are applied but user is not included', function (done) {
validService.restrictedTo = "other@domain.com";
storage.addService(validService, function (err, id) {
assert.ifError(err);
agent
.get(API_ROOT + '/services/outages')
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200)
.send()
.end(function (err, res) {
// TODO: Insert some outages and check
done(err);
});
});
});

it('should have access if restrictions include the current user', function (done) {
validService.restrictedTo = "user@domain.com";
storage.addService(validService, function (err, id) {
assert.ifError(err);
agent
.get(API_ROOT + '/services')
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200)
.send()
.end(function (err, res) {
// TODO: Insert some outages and check
done(err);
});
});
});
});

describe('with an authenticated admin user', function () {
before(function (done) {
agent.get('/login/test/1').expect(200, done);
});

it('should have access to all services', function (done) {
agent
.get(API_ROOT + '/services/outages')
.set('Accept', 'application/json')
.expect('Content-Type', /json/)
.expect(200)
.send()
.end(function (err, res) {
// TODO: Insert some outages and check
done(err);
});
});
});
});
});
28 changes: 28 additions & 0 deletions webserver/routes/api-report-route.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,34 @@ module.exports.getRoutes = function (storage){
return service;
}

/**
* Get latest service outages.
*/

router.get('/services/outages', function (req, res) {
// Creating request options and setting default values when necessary.
var options = {
since: req.query.since ? req.query.since : Date.now() - 3600,
maxItems: req.query['max-items'] ? req.query['max-items'] : 10,
maxItemsPerService: req.query['max-items-per-service'] ? req.query['max-items-per-service'] : 10,
grouping: req.query.grouping ? req.query.grouping : 0
};
storage.getServices({}, function (err, services) {
if (err) {
console.error(err);
return res.status(500).json({error: err});
}
var filteredServices = accessFilter.filterServices(services, req.user);
storage.getServicesOutagesSince(filteredServices, options, function (err, outages) {
if(err) {
console.error(err);
return res.statusCode(500).json({error: err});
}
res.json(outages);
})
});
});

/**
* Load service report
*/
Expand Down

0 comments on commit 692bc23

Please sign in to comment.