Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Replace private keyword with ECMAScript private fields #173

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Refactor: Replace private keyword with ECMAScript private fields #173

merged 2 commits into from
Feb 25, 2024

Conversation

ekamahuja
Copy link
Contributor

No description provided.

@ekamahuja ekamahuja marked this pull request as ready for review February 25, 2024 02:32
@ilovepixelart
Copy link
Owner

ilovepixelart commented Feb 25, 2024 •
edited
Loading

All good added check to disable sonar step for forked PRs, can you merge latest master to your forked branch @ekamahuja, lets see if it works

@ekamahuja
Copy link
Contributor Author

All good added check to disable sonar step for forked PRs, can you merge latest master to your forked branch @ekamahuja, lets see if it works

Looks like it worked! Btw if you get the chance to look at this (no rush) - #174

@ilovepixelart ilovepixelart merged commit e846475 into ilovepixelart:main Feb 25, 2024
8 checks passed
@ekamahuja ekamahuja deleted the private-ecma-# branch February 25, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilovepixelart ilovepixelart ilovepixelart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekamahuja @ilovepixelart