Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't search for text values with a space in "Mapping Values" interface #43

Closed
alanorth opened this issue Oct 15, 2020 · 2 comments
Closed

Can't search for text values with a space in "Mapping Values" interface #43

alanorth opened this issue Oct 15, 2020 · 2 comments
Labels
bug Something isn't working P-low Low priority

Comments

@alanorth
Copy link
Member

In the "Mapping Values" interface you cannot search for a value containing a space, for example New Zealand. You must search for either New or Zealand.

Screenshot_2020-10-15 OpenRXV-fs8
@alanorth alanorth added the bug Something isn't working label Oct 15, 2020
@alanorth alanorth added the P-low Low priority label Nov 23, 2020
ShacMiester added a commit to ShacMiester/OpenRXV that referenced this issue Feb 11, 2021
@ShacMiester
https://github.com/ilri/OpenRXV/issues/43
127edaf
@alanorth alanorth mentioned this issue Feb 11, 2021
Closed
@alanorth
Copy link
Member Author

alanorth commented Mar 3, 2021

I'm still seeing this issue even with the proposed patch above. For single-word values the search works, but it clearly does not work if you search for multiple words. See this video:

mapping-search-bug-trimmed.mp4

@alanorth
Copy link
Member Author

alanorth commented Nov 7, 2023

It seems this was partially addressed in #185. Now words with spaces are searched using a logical OR. For example "Volta Lake" returns mappings that have either "Volta" or "Lake":

Screenshot 2023-11-07 at 10-52-49 AReS

For now this is OK since we only have a small number of mappings.

@alanorth alanorth closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P-low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alanorth