Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements Oct 2023 #185

Merged
merged 106 commits into from
Nov 5, 2023
Merged

Enhancements Oct 2023 #185

merged 106 commits into from
Nov 5, 2023

Conversation

mohammadsalem
Copy link
Collaborator

No description provided.

@alanorth
Copy link
Member

Sharing some feedback here after testing more thoroughly:

  • Only 725 pages in Altmetric plugin? If that is 725*100 then there must be some missing?
  • On the Repository Setup page the save button is on the bottom, but on most others it is on the top
  • On the Repository Setup page I think the show/hide arrows on the repository setup page are opposite? ^ should be hiding the content
  • Collection filter has a weird blank space when scrolling down, I don't see this in other filters
  • Would it be possible to make the header for each section sticky so it stays at the top as you scroll? Not a huge thing, but some of the pages are really long
  • On the dashboard, I have a community filter using parentcommunitylist, but I don't see anything in the drop down
  • What is the syntax for the new advanced search? I tried accessRights:"Open Access" using the Elasticsearch field name and I think it is working... we don't need any documentation or anything, but if I know then I can help people use it

@mohammadsalem
Copy link
Collaborator Author

@alanorth thanks for the feedback!

  • Only 725 pages in Altmetric plugin? If that is 725*100 then there must be some missing?

In the DEV AReS not all handles are added in the plugins, but here is a comparison between the public API and the explorer API:
Public API number of records for each prefix:

Explorer API number of records for each prefix:

Note: The prefix 10947 is added to the plugins in the DEV server now.

  • On the Repository Setup page the save button is on the bottom, but on most others it is on the top

The button is moved to the top to go with the other pages.

  • On the Repository Setup page I think the show/hide arrows on the repository setup page are opposite? ^ should be hiding the content

Here I followed the same approach as for the explorer dashboard.
The arrows here represent the action to be done not the state, but we can change it in both places to represent the state if you think the current approach might be confusing.
Screenshot 2023-10-25 at 4 23 33 PM
Screenshot 2023-10-25 at 4 23 23 PM

  • Collection filter has a weird blank space when scrolling down, I don't see this in other filters

This is strange and it is appearing in other dropdowns as well, it looks like an issue with the dropdown plugin, as it appears in the dropdowns having many options with long text. It is also happening here https://cgspace.cgiar.org/explorer/. Will investigate more.

  • Would it be possible to make the header for each section sticky so it stays at the top as you scroll? Not a huge thing, but some of the pages are really long

Nice suggestion, it is applied!

  • On the dashboard, I have a community filter using parentcommunitylist, but I don't see anything in the drop down

parentcommunitylist was not included in the CGSpace schema, I've added it parentCommunity: parentcommunitylist.

  • What is the syntax for the new advanced search? I tried accessRights:"Open Access" using the Elasticsearch field name and I think it is working... we don't need any documentation or anything, but if I know then I can help people use it

The syntax is anything mentioned here https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html and it is using all default values except for two parameters:

  • default_operator it is set to AND.
  • fuzziness is set to auto

@alanorth
Copy link
Member

alanorth commented Oct 26, 2023

Thanks for the quick response. I see the changes are already live on the dev server. The sticky headers look great! And about the show/hide "^" I will look around the web and see how it is done elsewhere—something in my muscle memory feels backwards on that action.

Regarding Altmetric, let me check when I harvest tonight to see how many pages there are. I am surprised that there are so many, it should be 100 per page or 1000?

I also see you added the parentcommunitylist to the schema, maybe that was my fault, I think I removed it. Even so, I'm surprised there were no communities in the list. I will check again tonight after harvesting.


Minor feedback on consistent style:

  • can we have buttons for actions like cancel/stop on the left, and buttons for actions like start/commit on the right?
  • can we have buttons for actions like cancel/stop be red, and buttons for actions like start/commit be green?

Examples of inconsistency

Modal dialog on plugin start (red start button):

Pink commit button, plugin start/stop buttons in reverse logical order:

@alanorth
Copy link
Member

This morning I was investigating the Altmetric harvesting to try to understand if it is correct or not. The Altmetric plugin shows 731 pages:

Screenshot 2023-10-27 at 10-28-57 AReS

I looked up one item that was previously missing an attention badge in AReS and found it is missing entirely! I looked in both the Handle and DOI filters but cannot find the item, despite it being present on DSpace 7 Test:

So something funny going on...

@mohammadsalem
Copy link
Collaborator Author

  • The layout design adjustments are in place.
  • For Altmetric, the harvest for the real repositories (CGSpace, MELSpace and WorldFish DSpace) the total pages is 746 (100 per each page), however looking at the items in Elasticsearch with Altmetric data it is 19401 items
Screenshot 2023-10-29 at 4 23 27 PM Screenshot 2023-10-29 at 4 27 11 PM
  • BTW I noticed that many items are not matched with that is in Altmetric, I was investigating and found that these are deleted handles. I tried to match Altmetric API response for the prefixes defined in the plugin with the DOI not just the handle and got an additional 100 something matches! I think these are cases where an item was submitted twice with the same DOI and the one that was tweeted got deleted.

@alanorth
Copy link
Member

Thanks for the layout changes! Looking really good now. I love the sticky header!

As for the mysterious missing 10568/118261 handle, I swear it wasn't there when I checked. 🤔 Hmmm...

So I'm wondering about the 700+ pages of Altmetric mentions. That's 7,000 items with attention scores, but previously we were hitting limits on the free API because we were trying to crawl more than 1000 pages or so. The numbers don't make sense to me and it seems like we will be missing some scores.

Lastly, I'm thinking about a migration plan. It's good we can still harvest old DSpace instances so we can deploy the new code on a Sunday morning perhaps and you help me to make sure we get all the value mappings especially. Then we swap the indexes to the DSpace 7 sites once they are ready.

@mohammadsalem
Copy link
Collaborator Author

We were hitting the limit which was 100 pages (X 100 items per page = 10K items), now we are getting 700 something (X 100 items per page = 70K items) but only ~19.5K are matched with the handles harvested from the repositories.

Sure we can schedule a call and we do the migration together.

@alanorth
Copy link
Member

Oh yes of course, my math was off. Good so we are confident we are capturing as many of our outputs with attention scores as possible.

Let me think about the time schedule for the migration... talk soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants