Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: upgrade to Angular 10 #128

Closed
wants to merge 4 commits into from
Closed

frontend: upgrade to Angular 10 #128

wants to merge 4 commits into from

Conversation

alanorth
Copy link
Member

Upgrade frontend to Angular 10 using ngupgrade.

  1. First I did Angular itself (note I had to force the install due to peer dependencies):
$ npx @angular/cli@10 update --force @angular/core@10 @angular/cli@10
...
Package "ngx-tour-md-menu" has an incompatible peer dependency to "@angular/animations" (requires ">=7.0.0 <9.0.0" (extended), would install "10.2.5").
Package "ngx-loading" has an incompatible peer dependency to "@angular/common" (requires "^8.0.0" (extended), would install "10.2.5").
Package "@thisissoon/angular-inviewport" has an incompatible peer dependency to "@angular/core" (requires ">=5.0.0 <9.0.0" (extended), would install "10.2.5").
Package "ngx-tour-core" has an incompatible peer dependency to "@angular/router" (requires ">=7.0.0 <9.0.0" (extended), would install "10.2.5").
  1. Then I did Angular Material:
$ npx @angular/cli@10 update --force @angular/material@10
...
Package "@material-extended/mde" has an incompatible peer dependency to "@angular/cdk" (requires "^8.0.0 || ^9.0.0-0", would install "10.2.7").
Package "ngx-tour-md-menu" has an incompatible peer dependency to "@angular/material" (requires ">=7.0.0 <9.0.0", would install "10.2.7").
  1. Then I did @ngrx/store:
$ ng update @ngrx/store@10

The site builds and runs, including all charts on the homepage. I have not done an extensive check.

I used this command:

    $ npx @angular/cli@10 update --force @angular/core@10 @angular/cli@10
$ npx @angular/cli@10 update --force @angular/material@10
$ ng update @ngrx/store@10
@alanorth alanorth added enhancement New feature or request infrastructure Related to server or deployment labels Jan 24, 2022
@alanorth
Copy link
Member Author

alanorth commented May 5, 2022

Created a new OpenRXV instance based on this Angular 10 branch today and everything seems to work fine once I harvested some items and added a few filters, but there is some log spam:

ERROR Error: Uncaught (in promise): TypeError: can't access property "componentConfigs", this.dashboardConfig.find(...) is undefined
buildRawOptions@http://localhost/explorer/main-es2015.5a06419de4026fcf45e7.js:133449:54
start/<@http://localhost/explorer/main-es2015.5a06419de4026fcf45e7.js:133364:40
fulfilled@http://localhost/explorer/main-es2015.5a06419de4026fcf45e7.js:178759:58
invoke@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:479:30
onInvoke@http://localhost/explorer/main-es2015.5a06419de4026fcf45e7.js:48100:33
invoke@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:478:36
run@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:238:47
scheduleResolveOrReject/<@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:972:40
invokeTask@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:514:35
onInvokeTask@http://localhost/explorer/main-es2015.5a06419de4026fcf45e7.js:48088:33
invokeTask@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:513:40
runTask@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:282:51
drainMicroTaskQueue@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:684:39
invokeTask@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:599:25
invokeTask@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:1736:18
globalZoneAwareCallback@http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:1773:35
    resolvePromise http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:913
    makeResolver http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:820
    fulfilled http://localhost/explorer/main-es2015.5a06419de4026fcf45e7.js:178759
    invoke http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:479
    onInvoke http://localhost/explorer/main-es2015.5a06419de4026fcf45e7.js:48100
    invoke http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:478
    run http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:238
    scheduleResolveOrReject http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:972
    invokeTask http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:514
    onInvokeTask http://localhost/explorer/main-es2015.5a06419de4026fcf45e7.js:48088
    invokeTask http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:513
    runTask http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:282
    drainMicroTaskQueue http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:684
    invokeTask http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:599
    invokeTask http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:1736
    globalZoneAwareCallback http://localhost/explorer/polyfills-es2015.88477423697629e3e666.js:1773

@alanorth
Copy link
Member Author

alanorth commented Jul 8, 2023

Closed in favor of newer Angular 13 upgrade (#165).

@alanorth alanorth closed this Jul 8, 2023
@alanorth alanorth deleted the angular-10 branch July 8, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Related to server or deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant