Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XcSoar/XcVario sync problems continued! #144

Closed
GrahamD2 opened this issue Dec 31, 2021 · 10 comments
Closed

XcSoar/XcVario sync problems continued! #144

GrahamD2 opened this issue Dec 31, 2021 · 10 comments

Comments

@GrahamD2
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@hjr
Copy link
Contributor

hjr commented Jan 1, 2022

Hey Graham,

could you please add details to your report?

thx

@GrahamD2
Copy link
Author

GrahamD2 commented Jan 1, 2022

Helmut I thought I had
From issue #141 using https://github.com/iltis42/XCVario/blob/master/images/sensor-master-21.1230-1736.bin

Eckhard
I am beginning to regret mentioning the ballast sync issue, I rarely, if at all use water as it is!! The MC works great thanks
Bi-directional comms XCV-XCS with ballast has now caused a bigger problem than when it was not working.
With zero litres on both XCV and XCS on power up or when I open the flight setup page on XCS, 42l has already been loaded from XCV, closing the flight setup page writes back 42l to XCV, repeating the process next time 81l is then loaded to XCS which is then written back to XCV and so this continues each time I open the flight setup page,116l then 148l and so on. Pressing the Dump button in XCS produces some very interesting results!!!
It is not possible to zero the ballast on XCS while XCV is running.

Entering a figure on the flight setup in XCS always results in the same number writing to XCV so this is fine. The problem is the 40l or so that is added on startup or each time the flight setup page is open.

With XCS "Sync TO" device ON and Sync FROM device OFF. XCS flight setup updates XSV exactly. Changing the setting in XCV has no effect as you would expect.
With the Sync to and from setting reversed and with the ballast set to zero on both. restarting the XCV will load 42l into XCS flight setup.
I know you suggested I report to XCS but I don't want to find myself having a three way discussion when I don't really know the cause of the problem, would a developer to developer not be a better approach.
For my part I would happy if ballast sync was disabled until resolved, but I am happy to do further testing in the meantime if required.
Happy New Year

@iltis42
Copy link
Owner

iltis42 commented Jan 1, 2022

Dear Graham,
the issue reported looks like the reference data is not same in xcsoar and xcvario. Please check the reference wingload in xcvario and compare with the reference weight divided by wingarea in xcsoar, means reference wingload in xcsoar.
If there is still issue with same reference data, please open a new issue with this data on both sides, indicating the settings.
Please note that the issue with ballast transferred in android 7.21 from xcsoar cannot be solved in xcvario, so please kindly open issue there for wrong/cut precision of ballast sent.

@iltis42 iltis42 closed this as completed Jan 1, 2022
@GrahamD2
Copy link
Author

GrahamD2 commented Jan 1, 2022

I have checked these parameters and they match.
This serious problem only started when you fixed the no ballast response vario to xcs last week, can you unfix it?
I happy to raise a ticket with xcs but from what I can see is XCV is adding 40 litres each time it sends the data to XCS and I think if I tell them that they will bounce me back to you.
I clearly don't understand what is happening here
Turning off the sync from device in xcs (vario to xcs comms) solves the problem but I loose the function I really want, MC.
Graham

@iltis42
Copy link
Owner

iltis42 commented Jan 1, 2022

If there is no ballast reported from vario, there will be no update from vario, so this fix must stay. It may behave same as if you switch off sync from device, hence it may just cover another issue, but is not the root cause.
Please add screen shots of pictures from 'Polar Adjust' screen from vario and also 'Plane Details', showing wingarea plus 'Polar: ' dialog showing exact Reference Mass from xcsoar.

Repository owner deleted a comment from GrahamD2 Jan 1, 2022
@GrahamD2
Copy link
Author

GrahamD2 commented Jan 1, 2022 via email

@iltis42
Copy link
Owner

iltis42 commented Jan 1, 2022

The things i see here:
First:
xcsoar 377kg / 11.4m2 equals to 33.07 kg/m2, whereas setting in xcvario is 30.19 kg/m2.
Also the wingarea differs slightly 11.4 in xcsoar and 11.36 in vario.
Note this data must exactly match, otherwise it won't work.
Second:
Also please note that Borgelt Protocol cannot be used, only XCVario protocol has been extended to exchange more precise ballast data. Borgelt devices are in field as is, and cannot change their protocol, so now way to improve something there.
Third:
Tests with 6.8.11 are useless, even XCVario protocol is not using extended precision in this older version.
And i am sorry for that, but it looks like a functioning xcsoar version is currently not avail at the moment with this extension. Please also consider: The discussion about bug in xcsoar is considered as off topic in here.

@GrahamD2
Copy link
Author

GrahamD2 commented Jan 1, 2022 via email

@iltis42
Copy link
Owner

iltis42 commented Jan 1, 2022

Yes, i guess disable this at first shall be okay, hence i want to encourage you to write a bugreport in xcsoar when you encounter issues that are already confirmed, such as ballast precision is got cut in 7.21, otherwise a new version will never happen that fixed this problem.
An exact match for the masses is not needed, but as close as possible or less that 0.2% delta should be okay.
The protocol had been defined by cambridge long time ago and inherited to borgelt and xcvario. Limits in there are well known, and yes i agree there might be benefits from exchanging litres in future, hence its not the root cause of the trouble you see.
This simply comes first from different reference data, and second from rough ballast updates in the older version (solution for that already merged). And once your reference data is different, mostly all other polar calculations won't match, or at least do something that is very hard to explain e.g. different S2F, different netto vario, in both units.
The ballasting things are under work in xcsoar as well, xcvario is a bit advance providing crew weight and empty mass, but this will come this winter i guess.

@GrahamD2
Copy link
Author

GrahamD2 commented Jan 3, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants