Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a default message when there is none in DM #339 #443

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Conversation

Hasnayeen
Copy link
Owner

Make sure you've reviewed the checklist. (DO NOT REMOVE)

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the dev branch. Also you should start your branch off dev branch.
  • Check you have included issue number in your pr (e.g Add vue component for nav bar #23).
  • Check you have added tests that prove your fix is effective or that your feature works.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you added any notable changes to the CHANGELOG.md file.

Description

Fixes #339
💔Thank you!

@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #443 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #443   +/-   ##
=========================================
  Coverage     82.16%   82.16%           
  Complexity      341      341           
=========================================
  Files           113      113           
  Lines          1099     1099           
=========================================
  Hits            903      903           
  Misses          196      196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e2434...d93559b. Read the comment docs.

@Hasnayeen Hasnayeen merged commit 1ca0910 into dev Dec 10, 2018
@Hasnayeen Hasnayeen deleted the issue339 branch December 10, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants