Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java random numbers implementation #202

Merged
merged 8 commits into from
Mar 10, 2024
Merged

Java random numbers implementation #202

merged 8 commits into from
Mar 10, 2024

Conversation

Shanty97
Copy link
Contributor

Random Number between X and Y

  • Added Code for generating a random number between given x(inclusive) and y(inclusive)
  • Covered data types are byte, short, integer, long, float and double
  • Added and ran unit tests covering all datatypes

Throw A Dice (eg. 3d6)

  • Added code for generating the total sum from the given number of dice and number of sides
  • Added an Enum for covering the standard dice sides: 4, 6, 8, 10
  • Added and ran unit tests covering all dice sides

Test Report

Test-Report

CheckStyle Report - Main

CheckStyle-Main

CheckStyle Report - Test

CheckStyle-Test

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@iluwatar iluwatar merged commit 323bb50 into iluwatar:master Mar 10, 2024
1 check passed
@iluwatar
Copy link
Owner

Looks great! Thank you for the contribution 🎉

@Shanty97
Copy link
Contributor Author

@iluwatar My pleasure !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shanty97 @iluwatar