change according to cgeckstyle

iluwatar · Nov 10, 2019 · de56cbb · de56cbb
1 parent 74c7273
commit de56cbb
Show file tree

Hide file tree

Showing 27 changed files with 825 additions and 714 deletions.
diff --git a/saga/README.md b/saga/README.md
@@ -1,7 +1,7 @@
 ---
 layout: pattern
 title: Saga
-folder: Communication
+folder: saga
 permalink: /patterns/saga/
 categories: Behavioral
 tags:
@@ -43,4 +43,4 @@ Use the Saga pattern, if:
 - you can not use 2PC(two phase commit)
 
 ## Credits
-- [pattern description](https://microservices.io/patterns/data/saga.html)
+- [Pattern: Saga](https://microservices.io/patterns/data/saga.html)
diff --git a/saga/pom.xml b/saga/pom.xml
@@ -23,22 +23,23 @@
     THE SOFTWARE.
 
 -->
-<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
-  <modelVersion>4.0.0</modelVersion>
-  <parent>
-    <groupId>com.iluwatar</groupId>
-    <artifactId>java-design-patterns</artifactId>
-    <version>1.22.0-SNAPSHOT</version>
-  </parent>
+<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
+         xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>com.iluwatar</groupId>
+        <artifactId>java-design-patterns</artifactId>
+        <version>1.22.0-SNAPSHOT</version>
+    </parent>
 
-  <artifactId>saga</artifactId>
-  <dependencies>
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <scope>test</scope>
-    </dependency>
-  </dependencies>
+    <artifactId>saga</artifactId>
+    <dependencies>
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
 
 </project>
diff --git a/...m/iluwatar/saga/choreography/Chapter.java → ...aga/choreography/ChoreographyChapter.java b/...m/iluwatar/saga/choreography/Chapter.java → ...aga/choreography/ChoreographyChapter.java
@@ -24,37 +24,40 @@
 
 
 /**
- * Chapter is an interface representing a contract for an external service.
+ * ChoreographyChapter is an interface representing a contract for an external service.
  * In that case, a service needs to make a decision what to do further
  * hence the server needs to get all context representing {@link Saga}
- * */
-public interface Chapter {
-
-    /**
-     * In that case, every method is responsible to make a decision on what to do then
-     * @param saga incoming saga
-     * @return saga result
-     */
-    Saga execute(Saga saga);
-
-    /**
-     * @return service name.
-     */
-    String getName();
-
-    /**
-     * The operation executed in general case.
-     * @param saga incoming saga
-     * @return result {@link Saga}
-     */
-    Saga process(Saga saga);
-
-    /**
-     * The operation executed in rollback case.
-     * @param saga incoming saga
-     * @return result {@link Saga}
-     */
-    Saga rollback(Saga saga);
+ */
+public interface ChoreographyChapter {
+
+  /**
+   * In that case, every method is responsible to make a decision on what to do then
+   *
+   * @param saga incoming saga
+   * @return saga result
+   */
+  Saga execute(Saga saga);
+
+  /**
+   * @return service name.
+   */
+  String getName();
+
+  /**
+   * The operation executed in general case.
+   *
+   * @param saga incoming saga
+   * @return result {@link Saga}
+   */
+  Saga process(Saga saga);
+
+  /**
+   * The operation executed in rollback case.
+   *
+   * @param saga incoming saga
+   * @return result {@link Saga}
+   */
+  Saga rollback(Saga saga);
 
 
 }
diff --git a/saga/src/main/java/com/iluwatar/saga/choreography/FlyBookingService.java b/saga/src/main/java/com/iluwatar/saga/choreography/FlyBookingService.java
@@ -27,12 +27,12 @@
  * Class representing a service to book a fly
  */
 public class FlyBookingService extends Service {
-    public FlyBookingService(ServiceDiscoveryService service) {
-        super(service);
-    }
+  public FlyBookingService(ServiceDiscoveryService service) {
+    super(service);
+  }
 
-    @Override
-    public String getName() {
-        return "booking a Fly";
-    }
+  @Override
+  public String getName() {
+    return "booking a Fly";
+  }
 }
diff --git a/saga/src/main/java/com/iluwatar/saga/choreography/HotelBookingService.java b/saga/src/main/java/com/iluwatar/saga/choreography/HotelBookingService.java
@@ -27,14 +27,14 @@
  * Class representing a service to book a hotel
  */
 public class HotelBookingService extends Service {
-    public HotelBookingService(ServiceDiscoveryService service) {
-        super(service);
-    }
+  public HotelBookingService(ServiceDiscoveryService service) {
+    super(service);
+  }
 
-    @Override
-    public String getName() {
-        return "booking a Hotel";
-    }
+  @Override
+  public String getName() {
+    return "booking a Hotel";
+  }
 
 
-   }
+}
diff --git a/saga/src/main/java/com/iluwatar/saga/choreography/OrderService.java b/saga/src/main/java/com/iluwatar/saga/choreography/OrderService.java
@@ -26,14 +26,14 @@
 /**
  * Class representing a service to init a new order.
  */
-public class OrderService extends Service{
+public class OrderService extends Service {
 
-    public OrderService(ServiceDiscoveryService service) {
-        super(service);
-    }
+  public OrderService(ServiceDiscoveryService service) {
+    super(service);
+  }
 
-    @Override
-    public String getName() {
-        return "init an order";
-    }
+  @Override
+  public String getName() {
+    return "init an order";
+  }
 }