New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dirty Flag pattern Issue #883
Milestone
Comments
@iluwatar Can i take this. Thanks |
ranjeet-floyd
added a commit
to ranjeet-floyd/java-design-patterns
that referenced
this issue
Jun 11, 2019
ranjeet-floyd
added a commit
to ranjeet-floyd/java-design-patterns
that referenced
this issue
Jun 11, 2019
ranjeet-floyd
added a commit
to ranjeet-floyd/java-design-patterns
that referenced
this issue
Jun 11, 2019
Merged
Is this fixed already? |
Is this issue already resloved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
java-design-patterns/dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java
Line 60 in fedc2d9
Creating object of World class inside Thread's Run method doesn't make sense, as every time it is creating new object and reading the file. It should be outside this thread's run method.
for now it is like this
executorService.scheduleAtFixedRate(new Runnable() {
@OverRide
public void run() {
World world = new World();
List countries = world.fetch();
but it should be like this
executorService.scheduleAtFixedRate(new Runnable() {
World world = new World();
@OverRide
public void run() {
List countries = world.fetch();
The text was updated successfully, but these errors were encountered: