Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty Flag pattern Issue #883

Closed
sajankumarma opened this issue Jun 5, 2019 · 4 comments
Closed

Dirty Flag pattern Issue #883

sajankumarma opened this issue Jun 5, 2019 · 4 comments

Comments

@sajankumarma
Copy link

sajankumarma commented Jun 5, 2019

Creating object of World class inside Thread's Run method doesn't make sense, as every time it is creating new object and reading the file. It should be outside this thread's run method.

for now it is like this
executorService.scheduleAtFixedRate(new Runnable() {
@OverRide
public void run() {
World world = new World();
List countries = world.fetch();

but it should be like this
executorService.scheduleAtFixedRate(new Runnable() {
World world = new World();
@OverRide
public void run() {
List countries = world.fetch();

@ranjeet-floyd
Copy link
Contributor

ranjeet-floyd commented Jun 11, 2019

@iluwatar Can i take this. Thanks

ranjeet-floyd added a commit to ranjeet-floyd/java-design-patterns that referenced this issue Jun 11, 2019
ranjeet-floyd added a commit to ranjeet-floyd/java-design-patterns that referenced this issue Jun 11, 2019
ranjeet-floyd added a commit to ranjeet-floyd/java-design-patterns that referenced this issue Jun 11, 2019
@iluwatar
Copy link
Owner

Ok @ranjeet-floyd

@Rocangus
Copy link

Is this fixed already?

@OAkala
Copy link

OAkala commented Jul 12, 2019

Is this issue already resloved?

@iluwatar iluwatar added this to the 1.21.0 milestone Aug 4, 2019
iluwatar pushed a commit that referenced this issue Aug 4, 2019
@iluwatar iluwatar closed this as completed Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants