Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 11 support: Get rid of JavaEE, Corba and JavaFX #954

Closed
iluwatar opened this issue Oct 5, 2019 · 5 comments
Closed

Java 11 support: Get rid of JavaEE, Corba and JavaFX #954

iluwatar opened this issue Oct 5, 2019 · 5 comments
Labels
epic: dependencies info: good first issue info: help wanted
Milestone
1.22.0

Comments

@iluwatar
Copy link
Owner

iluwatar commented Oct 5, 2019

This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition

Java EE, Corba and JavaFX have been deprecated in newer JDK versions. Are there any dependencies to those in this project? If there is, we should get rid of them. (see https://blog.codefx.org/java/java-9-migration-guide/)
jarpit96 added a commit to jarpit96/java-design-patterns that referenced this issue Oct 5, 2019
@jarpit96
Fix for issue iluwatar#954
dee4b8c 
Add javax.annotation and java.xml.bind as external maven dependencies
Verified with jdk-11
@jarpit96
Copy link
Contributor

jarpit96 commented Oct 5, 2019

Hi, I have created a pull request for this issue.

@jarpit96
Copy link
Contributor

jarpit96 commented Oct 5, 2019

#957

@ryantheleach
Copy link

A lot of this stuff has just been migrated to community projects...

Shouldn't J-EE move to Jakarta? I didn't think J-EE was truly deprecated.
JavaFX to https://openjfx.io/

@iluwatar
Copy link
Owner Author

iluwatar commented Oct 6, 2019

@ryantheleach yes, I agree that stuff should be moved and not totally removed. Maybe an inaccurate term there in the issue subject..

@iluwatar
Copy link
Owner Author

iluwatar commented Oct 6, 2019

Links:
https://blog.codefx.org/java/java-9-migration-guide/#Dependencies-On-Java-EE-Modules
https://jaxenter.com/jdk-11-java-ee-modules-140674.html

iluwatar pushed a commit that referenced this issue Oct 6, 2019
@jarpit96 @iluwatar
Fix for issue #954 : Add external Dependencies to run with Java11 (#957)
94ca254 
* Fix for issue #954
Add javax.annotation and java.xml.bind as external maven dependencies
Verified with jdk-11

* Move dependency versions to main pom.xml's dependencyManagement section
@iluwatar iluwatar added this to the 1.22.0 milestone Oct 6, 2019
@iluwatar iluwatar closed this as completed Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic: dependencies info: good first issue info: help wanted
Projects
None yet
Milestone
1.22.0
Development

No branches or pull requests
3 participants
@ryantheleach @iluwatar @jarpit96