Update creating mechanism. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test dependency is added.
fixed the issue with class creation.
|
Added double checked locking. |
|
|
||
| public static IvoryTower getInstance() { | ||
| if(instance == null){ |
There was a problem hiding this comment.
The lazy initialization of the object introduces concurrent access problem (the access to the singleton object is not thread safe anymore).
There was a problem hiding this comment.
Oh ok, I can avoid that with locking but it's not super important though. :) I'll skip this update.
|
The double checked locking pattern looks good. Can you also provide simple class diagram image (inventory has items)? I've used https://www.genmymodel.com/ for drawing. Please add pattern description to README.md and link to the class diagram. |
|
I'll add the pattern description to README.md as soon as I can :) |
|
Ping? |
iluwatar
pushed a commit
that referenced
this pull request
Jan 1, 2016
Generate UML for delegation pattern
npathai
pushed a commit
that referenced
this pull request
Aug 4, 2016
merging changes into fork from origin
iluwatar
pushed a commit
that referenced
this pull request
Jan 13, 2017
#450 Queue-Based-Load-Leveling Blog
iluwatar
pushed a commit
that referenced
this pull request
May 15, 2017
iluwatar
pushed a commit
that referenced
this pull request
Sep 23, 2017
#348 - Data Tranfer Object : Add Puml id to README.md.
wangihzyue
added a commit
to wangihzyue/java-design-patterns
that referenced
this pull request
May 19, 2021
issue1260 change
mahendher
pushed a commit
to mahendher/java-design-patterns
that referenced
this pull request
Dec 9, 2021
pratigya0
pushed a commit
to pratigya0/java-design-patterns
that referenced
this pull request
Aug 3, 2023
Updated Terraform Section
pratigya0
pushed a commit
to pratigya0/java-design-patterns
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation mechanism for IvoryTower is updated.