847

[vdlald]

Relates to #847

Pull request description

• remove methods for test
• remove boilerplate code via Lombok

[ravening]

You can use @Data instead of adding getter and setter to each field

[vdlald]

Yes, I can, but it seemed to me that the annotation @Data is not quite suitable for the class App. Usually, the classes called App are needed to run an application. When I look at this class, I get the feeling that there is another class called Kingdom. I propose to move the fields king, castle, army and static class FactoryMaker from class App to a new class Kingdom (where I can use the annotation @Data) and in App to use an object of class Kingdom. This option seems cleaner to me. What do you think about it?

[ravening]

Yeah you can do that as well

[iluwatar]

Please let me know when its ready for another review

[vdlald]

Please let me know when its ready for another review

I made the request for review via github, a request did not reach you?

[vdlald]

Need to be reviewed

[ravening]

Need to be reviewed

Do you want till #1503 gets completed else the code will have boilerplate code for getters and setters

[vdlald]

I removed lombok from the commit 2e36a11.

[ravening]

You can refactor it to

Supplier<Kingdom> kingdomSupplier = Kingdom::new

...

public Kingdom getKingdom() {
    return kingdomSupplier.get();
}

but its upto you

[vdlald]

I don't quite understand why. Can you explain it in more detail?

[iluwatar]

Many thanks for this improvement!

@all-contributors please add @vdlald for code

[allcontributors]

@iluwatar

I've put up a pull request to add @vdlald! 🎉

[vdlald]

Thanks!