Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring #1960

Closed
wants to merge 3 commits into from
Closed

Code refactoring #1960

wants to merge 3 commits into from

Conversation

ShivanshCharak
Copy link
Contributor

Pull request title

Code Refactored reduced cognitive complexity from 42 to 15

Pull request description
Link of the issue
https://sonarcloud.io/project/issues?id=iluwatar_java-design-patterns&open=AW3G0WIhwB6UiZzQNqtw&resolved=false&severities=CRITICAL

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

@ShivanshCharak ShivanshCharak mentioned this pull request Feb 1, 2022
Closed
iluwatar
iluwatar requested changes Feb 12, 2022
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing, apparently due to Checkstyle issues.

@iluwatar iluwatar self-assigned this Feb 12, 2022
@ShivanshCharak
Copy link
Contributor Author

So it is my issue or server side if my issue can I fix it

@ShivanshCharak
Copy link
Contributor Author

Actually I am done with other critical issue too so should I reduce the checkstyle issue is it my part or should I just raise a pr with all those checksum issues

@iluwatar
Copy link
Owner

Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project acyclic-visitor: You have 1 Checkstyle violation.

@iluwatar
Copy link
Owner

Please fix the errors reported by Checkstyle @ShivanshCharak

@stale
Copy link

stale bot commented Oct 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Oct 30, 2022
@iluwatar
Copy link
Owner

iluwatar commented Nov 9, 2022

Closed due to inactivity

@iluwatar iluwatar closed this Nov 9, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar requested changes

Assignees

@iluwatar iluwatar

Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShivanshCharak @iluwatar