Refactor: remove code smell java:S5786 #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertvolkmann
force-pushed
the
refactor/default-package-visibility
branch
from
5583d73
to
b09e3a6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
iluwatar
approved these changes
Oct 30, 2022
|
Nice to get some of those smells fixed, thank you! @all-contributors please add @robertvolkmann for code |
|
@robertvolkmann already contributed before to code |
robertvolkmann
added a commit
to robertvolkmann/java-design-patterns
that referenced
this pull request
Nov 6, 2022
robertvolkmann
added a commit
to robertvolkmann/java-design-patterns
that referenced
this pull request
Nov 6, 2022
This reverts commit e3bb116.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes at least 125 code smells of severity info.
https://sonarcloud.io/organizations/iluwatar/rules?open=java%3AS5786&rule_key=java%3AS5786
Fix some code smells #1012