Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Spanish translation for Singleton Pattern #2627

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Added Spanish translation for Singleton Pattern #2627

merged 4 commits into from
Oct 25, 2023

Conversation

Yenniferh
Copy link
Contributor

@Yenniferh Yenniferh commented Oct 8, 2023 •
edited

Translates the Singleton Pattern to Spanish

Task of #2277

miguel-is-coding
miguel-is-coding suggested changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@miguel-is-coding miguel-is-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found one need to change in line 4. The other changes requested are regarding to translations according to the context.

Thanks for your time!

localization/es/singleton/README.md Outdated
---
title: Singleton
category: Creational
language: en
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change language here to es, like this:

language: es

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

localization/es/singleton/README.md Outdated
- Gang of Four
---

## Intención
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this context, I think is better to use Propósito instead of Intención, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

localization/es/singleton/README.md Outdated
> Solo puede haber una torre de marfil donde los magos estudian su magia. La misma torre de marfil encantada
> siempre es utilizada por los magos. La torre de marfil aquí es un singleton.

En palabras simples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, for the context, I think it fits better En otras palabras

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Yenniferh
Copy link
Contributor Author

Thanks for your suggestions, @miguel-is-coding. All were implemented.

miguel-is-coding
miguel-is-coding approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@miguel-is-coding miguel-is-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miguel-is-coding
Copy link
Contributor

@iluwatar who should be assigned to review and approve this? thanks

@iluwatar iluwatar merged commit 4654288 into iluwatar:master Oct 25, 2023
1 check passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @miguel-is-coding for review

@allcontributors allcontributors bot mentioned this pull request Oct 25, 2023
Merged
@allcontributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @miguel-is-coding! 🎉

sugan0tech pushed a commit to sugan0tech/java-design-patterns that referenced this pull request Nov 12, 2023
@Yenniferh @sugan0tech
translation: Added Spanish translation for Singleton Pattern (iluwata…
e86c92e 
…r#2627)

* Translates Singleton Pattern to Spanish for iluwatar#2277

* Fixes the class diagram path

* ADD: Suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

@miguel-is-coding miguel-is-coding miguel-is-coding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yenniferh @miguel-is-coding @iluwatar