Commit *.lock files #276
Merged
Commit *.lock files #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmaples
force-pushed
the
commit-lock-files
branch
2 times, most recently
from
7cd44f1
to
ecf21e0
Compare
wildmaples
force-pushed
the
commit-lock-files
branch
from
ecf21e0
to
25d13b8
Compare
|
Rails 6.0 is not compatible with Ruby 3.0 and above. Both Rails 6.0 and Ruby 2.7 has reached EOL. I propose we stop supporting version Rails 6.0. The question of why/how the CI check was passing before will be another conversation 😬 |
wildmaples
force-pushed
the
commit-lock-files
branch
from
3ce12ef
to
e5af2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open source projects these days should commit their lockfiles. Not committing lockfiles is a fairly outdated policy/concept. With the advent of better CI and matrix builds, this Gemfile.lock policy is no longer the case. You’ll see a lot of popular gem projects now check in their lockfile. This is because it makes setting up development easier and more predictable. In 2010, CI practices were not as robust as they are today so using the “randomness” of no lockfile helped suss out edge cases.