Run CI tests on the latest LTS Node.js release #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyavolodin
approved these changes
Aug 15, 2017
|
Wow, this is really interesting. I didn't realize the tests were running in Node 0.10. I have no idea how they were passing, since ESLint dropped support for Node 0.10 very long time ago (I think it was before it hit 1.0.0, due to Mocha issues). Thanks for noticing, and fixing! |
|
I'm still not sure why the tests passed in these PRs and failed on master. Hopefully this fixes it. |
|
Yes, I have no explanation for it either... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will run tests with support for ES8 syntax.
Also, fix formatting errors in README.