Sourcery Starbot ⭐ refactored ilyeshammadi/django-publishable #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcery-ai-bot
commented
Feb 10, 2023
Comment on lines
-13
to
+17
| if not DraftController.is_draft: | ||
| return queryset.filter(type=TYPES.PUBLISHED) | ||
| return queryset.filter(type=TYPES.DRAFT, is_deleted=False) | ||
| return ( | ||
| queryset.filter(type=TYPES.DRAFT, is_deleted=False) | ||
| if DraftController.is_draft | ||
| else queryset.filter(type=TYPES.PUBLISHED) | ||
| ) |
There was a problem hiding this comment.
Function select_from_queryset refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
| # Delete the previous published to save space | ||
| previous_published_id = None | ||
| if self.published: | ||
| previous_published_id = self.published.id | ||
|
|
||
| previous_published_id = self.published.id if self.published else None |
There was a problem hiding this comment.
Function Publishable.publish refactored with the following changes:
- Move setting of default value for variable into
elsebranch (introduce-default-else) - Replace if statement with if expression (
assign-if-exp)
This removes the following comments ( why? ):
# Delete the previous published to save space
Comment on lines
-122
to
+119
| else: | ||
| self.is_deleted = True | ||
| self.save() | ||
| self.is_deleted = True | ||
| self.save() |
There was a problem hiding this comment.
Function Publishable.delete refactored with the following changes:
- Swap positions of nested conditionals [×2] (
swap-nested-ifs) - Hoist nested repeated code outside conditional statements [×2] (
hoist-similar-statement-from-if) - Swap if/else branches [×2] (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-138
to
+137
| if Draft.objects.filter(object_id=self.id).exists(): | ||
| draft = Draft.objects.get(object_id=self.id) | ||
| else: | ||
| draft = Draft.objects.create(content_object=self) | ||
| return draft | ||
| return ( | ||
| Draft.objects.get(object_id=self.id) | ||
| if Draft.objects.filter(object_id=self.id).exists() | ||
| else Draft.objects.create(content_object=self) | ||
| ) |
There was a problem hiding this comment.
Function Publishable.broadcast_need_to_published refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
developbranch, then run: