Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Rename 'metric' config key to conform to the metrics module naming #100

Closed
archaron opened this issue Aug 24, 2021 · 1 comment · Fixed by #112
Closed

Rename 'metric' config key to conform to the metrics module naming #100

archaron opened this issue Aug 24, 2021 · 1 comment · Fixed by #112
Assignees
@im-kulikov
Labels
bug Something isn't working
Milestone
v0.14.0

Comments

@archaron
Copy link
Contributor

It is not obvious, why the config key is named as 'metric' instead of logically correct (IMHO) 'metrics'.

helium/web/servers.go

Line 83 in 0a5977e

metricsServer = "metric"

I suggest renaming it to conform to the module naming. This will help to avoid future misunderstands and mistakes in config files.
@im-kulikov im-kulikov self-assigned this Aug 24, 2021
@im-kulikov im-kulikov added the bug Something isn't working label Aug 24, 2021
@im-kulikov im-kulikov added this to the v0.14.0 milestone Aug 24, 2021
im-kulikov added a commit that referenced this issue Aug 28, 2021
@im-kulikov
Prepare ops server
712e80a 
fix #100
@im-kulikov
Copy link
Owner

@archaron thx for the issue, pls take a look at ops-server (web.OpsModule) it will replace the next servers with endpoints

  • metrics
  • profile

In the future, I propose to drop web.ProfilerModule and web.MetricsModule.

im-kulikov added a commit that referenced this issue Jan 27, 2022
@im-kulikov
Fix #100 drop pprof and metrics separated servers
ad66aa1 
- use ops server as drop replacement
- fix grpc.WithInsecure deprecation warning

closes #100
@im-kulikov im-kulikov mentioned this issue Jan 27, 2022
Merged
im-kulikov added a commit that referenced this issue Jan 27, 2022
@im-kulikov
Merge pull request #112 from im-kulikov/fix-issue-100
bf77504 
Fix #100 drop pprof and metrics separated servers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@im-kulikov im-kulikov

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging a pull request may close this issue.

Fix #100 drop pprof and metrics separated servers im-kulikov/helium
2 participants
@archaron @im-kulikov