Update: ensure mouse events are on shadow root #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support react components that use the onMouseDown, or onMouseUp. Currently these events are still being attached to the document instead of the shdaow root
stevematney
commented
Nov 17, 2020
stevematney
commented
Nov 19, 2020
Comment on lines
+62
to
+66
| set retargetCleanup(cleanupFunction: () => void) { | ||
| // Ensure that we cleanup an old listeners before we forget the cleanup function. | ||
| this.retargetCleanup(); | ||
| this.retargetCleanupFunction = cleanupFunction; | ||
| } |
There was a problem hiding this comment.
We still need to run this setter when we call retargetReactEvents.
There was a problem hiding this comment.
I thought I had done that. I guess I thought about it too much, but never did add the setters. Okay so this should work now.
Nayshlok
force-pushed
the
ensure-mouse-events-retarget
branch
from
42f33fe
to
9b5cdea
Compare
|
It looks like this is failing to build. |
Nayshlok
force-pushed
the
ensure-mouse-events-retarget
branch
from
9b5cdea
to
49615d1
Compare
I had accidentally left in a test to adding onClick. We do not want this functionality as the current system for retargeting works for clicks
Also added node modules to be excluded from tsconfig
Nayshlok
force-pushed
the
ensure-mouse-events-retarget
branch
from
266afce
to
163b178
Compare
JosephDSchwartz
approved these changes
Nov 20, 2020
|
Since I opened this PR, I can't approve it, but with Joseph's approval (and my unofficial approval), I'm merging. 😄 |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support react components that use the onMouseDown, or
onMouseUp. Currently these events are still being attached to the
document instead of the shdaow root