Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGSEVERE and LOGNOTICE will deprecated in kodi/python addons #205

Closed
phunkyfish opened this issue Aug 29, 2020 · 9 comments · Fixed by #217
Closed

LOGSEVERE and LOGNOTICE will deprecated in kodi/python addons #205

phunkyfish opened this issue Aug 29, 2020 · 9 comments · Fixed by #217
Labels
enhancement New feature or request
Milestone

Comments

@phunkyfish
Copy link

Please replace with LOGFATAL and LOGINFO. They will be removed in a couple of weeks.

PR: xbmc/xbmc#18346
Forum Post: https://forum.kodi.tv/showthread.php?tid=353818

@im85288
Copy link
Owner

im85288 commented Sep 16, 2020

@MoojMidge @dagwieers Where are we with this one? It's starting to fail on Nightlies so want to either merge in or update

MoojMidge referenced this issue in MoojMidge/service.upnext Sep 17, 2020
@MoojMidge
Copy link
Collaborator

Just created a PR to address this specific issue (#213).

I was looking for a bit of guidance about the larger changes in case it was needed to reformat/restructure things, as I had previously already gone ahead and made a number of changes that impact on the module structure and formatting (#206 (comment))

im85288 added a commit that referenced this issue Sep 17, 2020
Update logging function to address #205
@im85288
Copy link
Owner

im85288 commented Sep 17, 2020

Thanks that's merged now. Let's give @dagwieers some time to come back with feedback on your other PR's as he is more up to date with the latest code base than I am. If we haven't heard back in say a week I'll step in. Your changes look cool so we will get them in some how, cheers

@rikardfries
Copy link

I may be to fast here with my comment, but I do not see the update in Kodi yet..

@phunkyfish
Copy link
Author

It’s merged, here: xbmc/xbmc#18346

@rikardfries
Copy link

Sorry for the confusion, my apoligies, I meant the service.upnext update.

It’s merged, here: xbmc/xbmc#18346

@im85288
Copy link
Owner

im85288 commented Sep 19, 2020

It’s currently only merged with the latest and greatest, so if using a nightlie version of Kodi you would need to get the code directly. A release will come at some stage but not quite yet.

@rikardfries
Copy link

It’s currently only merged with the latest and greatest, so if using a nightlie version of Kodi you would need to get the code directly. A release will come at some stage but not quite yet.

Ah, perfect then I understand. Thank you.

@dagwieers dagwieers added the enhancement New feature or request label Sep 26, 2020
@dagwieers dagwieers added this to the v1.2.0 milestone Sep 26, 2020
@dagwieers dagwieers modified the milestones: v1.2.0, v1.1.3 Oct 11, 2020
@dagwieers
Copy link
Collaborator

We are preparing the release of v1.1.3, please help in testing this as wide as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants