-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOGSEVERE and LOGNOTICE will deprecated in kodi/python addons #205
Comments
@MoojMidge @dagwieers Where are we with this one? It's starting to fail on Nightlies so want to either merge in or update |
(cherry picked from commit e175596)
Just created a PR to address this specific issue (#213). I was looking for a bit of guidance about the larger changes in case it was needed to reformat/restructure things, as I had previously already gone ahead and made a number of changes that impact on the module structure and formatting (#206 (comment)) |
Update logging function to address #205
Thanks that's merged now. Let's give @dagwieers some time to come back with feedback on your other PR's as he is more up to date with the latest code base than I am. If we haven't heard back in say a week I'll step in. Your changes look cool so we will get them in some how, cheers |
I may be to fast here with my comment, but I do not see the update in Kodi yet.. |
It’s merged, here: xbmc/xbmc#18346 |
Sorry for the confusion, my apoligies, I meant the service.upnext update.
|
It’s currently only merged with the latest and greatest, so if using a nightlie version of Kodi you would need to get the code directly. A release will come at some stage but not quite yet. |
Ah, perfect then I understand. Thank you. |
We are preparing the release of v1.1.3, please help in testing this as wide as possible. |
Please replace with LOGFATAL and LOGINFO. They will be removed in a couple of weeks.
PR: xbmc/xbmc#18346
Forum Post: https://forum.kodi.tv/showthread.php?tid=353818
The text was updated successfully, but these errors were encountered: