-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when kodi is not playing video any longer #298
Conversation
Thanks for this. Properly handling the In this particular instance however, catching the exception is probably not quite the right fix. The actual code in service.upnext/resources/lib/playitem.py Line 61 in 147ed85
Also there is no need to update the changelog and bump the version number, as that is done as part of a separate PR in order to trigger the release workflow. |
@AnonTester - did you want to update this? |
@MoojMidge adjusted to remove version and changelog and changing the try/catch which works for me with your suggestion instead. |
Hmm looks like this uncovered a previous old issue - |
Kudos, SonarCloud Quality Gate passed! |
Fixes timing issue that sometimes pops up when stopping or forward skipping at end of movie/show just as UpNext is starting up resulting in error:
error : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'RuntimeError'>
Error Contents: Kodi is not playing any file
Traceback (most recent call last):
File "/home/kodi/.kodi/addons/service.upnext/resources/lib/service_entry.py", line 8, in
UpNextMonitor().run()
File "/home/kodi/.kodi/addons/service.upnext/resources/lib/monitor.py", line 109, in run
self.playback_manager.launch_up_next()
File "/home/kodi/.kodi/addons/service.upnext/resources/lib/playbackmanager.py", line 44, in launch_up_next
episode, source = self.play_item.get_next()
File "/home/kodi/.kodi/addons/service.upnext/resources/lib/playitem.py", line 61, in get_next
current_file = self.player.getPlayingFile()
RuntimeError: Kodi is not playing any file
-->End of Python script error report<--