Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Add optional pre-commit checks for the package. #93

Closed
imAsparky opened this issue Sep 16, 2021 · 0 comments · Fixed by #99
Closed

[FEAT]: Add optional pre-commit checks for the package. #93

imAsparky opened this issue Sep 16, 2021 · 0 comments · Fixed by #99
Assignees
@imAsparky
Labels
enhancement New feature or request
Projects
Built Py3-Package Features.

Comments

@imAsparky
Copy link
Owner

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@imAsparky imAsparky added the enhancement New feature or request label Sep 16, 2021
@imAsparky imAsparky self-assigned this Sep 16, 2021
@imAsparky imAsparky added this to To do in Built Py3-Package Features. via automation Sep 16, 2021
imAsparky added a commit that referenced this issue Sep 16, 2021
@imAsparky
feat(pre-commit): Add pre-commit to package #93
8fa9659 
* Pre-commit added to reduce the effort for developers to check their
  work.
* I have added missing checks to test_bake_with_defaults.
* I have fixed some logic in the post_gen.py file about deleting the
  CHANGELOG.md file and added a test for that.

closes #93
@imAsparky imAsparky mentioned this issue Sep 16, 2021
Merged
Built Py3-Package Features. automation moved this from To do to Done Sep 16, 2021
imAsparky added a commit that referenced this issue Sep 16, 2021
@imAsparky
feat(pre-commit): Add pre-commit to package #93 (#99)
5ec4067 
* Pre-commit added to reduce the effort for developers to check their
  work.
* I have added missing checks to test_bake_with_defaults.
* I have fixed some logic in the post_gen.py file about deleting the
  CHANGELOG.md file and added a test for that.

closes #93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imAsparky imAsparky

Labels
enhancement New feature or request
Projects
Built Py3-Package Features.
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pre-commit): Add pre-commit to package #93 imAsparky/cookiecutter-py3-package
1 participant
@imAsparky