Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rust Client to list of SDK's #203

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Add Rust Client to list of SDK's #203

merged 2 commits into from
Mar 19, 2024

Conversation

Atoo35
Copy link
Contributor

@Atoo35 Atoo35 commented Mar 16, 2024

I am back with adding a new rust client for the pantry API.

@Atoo35
Update sdk.ts
d3719bb 
Added rust client
@imRohan imRohan self-requested a review March 18, 2024 14:02
@imRohan imRohan added the Ready for Review Once you've squashed your commits, the PR is now ready for review! label Mar 18, 2024
imRohan
imRohan requested changes Mar 18, 2024
View reviewed changes
Copy link
Owner

@imRohan imRohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'm excited that there is a Rust SDK available for Pantry!

Looks like the linter is not happy with your changes, you might be missing a comma somewhere.

Also, let's rename your PR to Add Rust Client to List of SDK's

@Atoo35 Atoo35 changed the title Update sdk.ts Add Rust Client to list of SDK's Mar 18, 2024
@Atoo35
Copy link
Contributor Author

Atoo35 commented Mar 18, 2024

@imRohan I am excited too, learning rust along with building.
Anyway I fixed both the changes requested!!

@imRohan imRohan self-requested a review March 19, 2024 13:27
@imRohan imRohan merged commit 84e76ba into imRohan:master Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imRohan imRohan imRohan approved these changes

Assignees

@Atoo35 Atoo35

Labels
Ready for Review Once you've squashed your commits, the PR is now ready for review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Atoo35 @imRohan