Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black shadows are default on since 0.9.2 #316

Closed
krispypen opened this issue Apr 23, 2020 · 2 comments · Fixed by #319
Closed

Black shadows are default on since 0.9.2 #316

krispypen opened this issue Apr 23, 2020 · 2 comments · Fixed by #319
Labels
bug Something isn't working Line Chart

Comments

@krispypen
Copy link
Contributor

krispypen commented Apr 23, 2020

Since version 0.9.2 , PR #305 , every line has a shadow, this should not be standard behavior.

My suggestion is to add a color property to the default " ?? const Shadow()" at https://github.com/imaNNeoFighT/fl_chart/blob/ef6ee3f882cbb01a5661c998fa67633f1c23144d/lib/src/chart/line_chart/line_chart_data.dart#L393
and set it to Colors.transparent . Then it's ignored during rendering in the _drawBarShadow method because the opacity is 0.0

Not 100% sure but if that's the best solution, I can create a PR too

@imaNNeo
Copy link
Owner

imaNNeo commented Apr 23, 2020

Yes, that's the best solution,
make a PR dude.
Thanks!

@imaNNeo imaNNeo added Line Chart bug Something isn't working labels Apr 23, 2020
@imaNNeo imaNNeo mentioned this issue Apr 23, 2020
@imaNNeo
Copy link
Owner

imaNNeo commented Apr 23, 2020

Fixed in 0.9.3,
Thanks for reporting!
And for sure thanks for contributing!

ezmegy pushed a commit to ezmegy/fl_chart that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Line Chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants