Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gradient color to range annotations, issue #1195. #1294

Merged

Conversation

MagdyYacoub1
Copy link
Contributor

Resolving issue #1195

Added gradient attribute to horizontalRangeAnnotations and VerticalRangeAnnotation.

This will help specify gradient or solid color to range annotations. If none were identified, it would use a solid whit color.

@imaNNeo
Copy link
Owner

imaNNeo commented Apr 9, 2023

Ready to merge, but before that please update the line_chart docs

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #1294 (02a3bc6) into master (68917b0) will decrease coverage by 0.04%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
- Coverage   85.94%   85.90%   -0.04%     
==========================================
  Files          45       45              
  Lines        2945     2958      +13     
==========================================
+ Hits         2531     2541      +10     
- Misses        414      417       +3     
Impacted Files Coverage Δ
lib/src/chart/bar_chart/bar_chart.dart 0.00% <0.00%> (ø)
lib/src/chart/line_chart/line_chart.dart 0.00% <0.00%> (ø)
lib/src/chart/scatter_chart/scatter_chart.dart 0.00% <0.00%> (ø)
.../src/chart/base/axis_chart/axis_chart_painter.dart 72.51% <45.28%> (+1.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Updated comments in axis_chart_data.dart to explain the behaviour of both attributes
@MagdyYacoub1
Copy link
Contributor Author

Thank you for your reply.
I updated the documentation of the horizontalRangeAnnotations and VerticalRangeAnnotation by adding the gradient attribute to their tables.
Also, I updated the comments in the ''axis_chart_data.dart'' to explain more the color and gradient attributes behavior when both provided or not provided.

@imaNNeo
Copy link
Owner

imaNNeo commented Apr 11, 2023

Great!
Thanks for contributing.

@imaNNeo imaNNeo merged commit ce9f1d7 into imaNNeo:master Apr 11, 2023
2 of 4 checks passed
@MagdyYacoub1 MagdyYacoub1 deleted the improvement/range_annotations_gradient branch April 15, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants