Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tooltip not displaying when value from BackgroundBarChartRodData is less than zero #1378

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

Anas35
Copy link
Contributor

@Anas35 Anas35 commented Jun 26, 2023

Added backDrawRodData's y-axis to take in account when calculating pixels.
close #1345

@Anas35 Anas35 changed the title **BUGFIX** Fix Tooltip not displaying when value from BackgroundBarChartRodData is less than zero Fix: Tooltip not displaying when value from BackgroundBarChartRodData is less than zero Jun 26, 2023
@imaNNeo
Copy link
Owner

imaNNeo commented Jul 7, 2023

Thank you very much!

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1378 (52020ae) into master (c6eca89) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1378   +/-   ##
=======================================
  Coverage   86.08%   86.09%           
=======================================
  Files          45       45           
  Lines        2976     2978    +2     
=======================================
+ Hits         2562     2564    +2     
  Misses        414      414           
Impacted Files Coverage Δ
lib/src/chart/bar_chart/bar_chart_painter.dart 92.18% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imaNNeo imaNNeo merged commit 478e5e6 into imaNNeo:master Jul 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip not displaying when touched value from BackgroundBarChartRodData is less than zero.
2 participants