Remove unwanted shadow and Add TextStyle for Tab label #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi dude, |
|
@imaNNeoFighT Sure! What needs to be changed there? |
|
We need to update sample codes, and also if you have sketch in your machine, please update the CheatSheet (using this file). |
|
I have updated the sample code in this PR already but I'm afraid there is no possibility for me to modify the file you just mentioned. |
|
Aint it gonna be merged? :-? |
|
Yeap, just wait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the artwork in Uplabs the icons must have no shadow and follow the flat colors.
So I removed it and you can see the changes here:
I made changes so users can pass style for label of each
TabItem, of course it is notrequiredand there is some default style for when the user leaves it empty (Bold) . This feature is added to fix issue Textsize of Menu titile #6