-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: refactor points and add absolute coords calculation #472
feat!: refactor points and add absolute coords calculation #472
Conversation
refactor!: change return type to Point[] feat!: allow calculating relative and absolute coords
I didn't expect the generator to be a private method.
|
We decided that it would be easier that the generator would treat both cases for absolute and relative coordinates. And since the code for both getters became similar, we decided to put it into one getter with a parameter that lets the user choose what kind of coordinates one wants. The coordinates are still cached separately though. |
That is not contradicting what @targos said. The point is that it should not be private.
It's no longer a "getter" if it takes parameters. Let's go with the initial idea: |
API SGTM but the documentation explanations related to the new fields don't seem clear enough to me. We should discuss it IRL. |
I wrote "Images/Masks" instead of "RoiMap" for absolute coordinates because RoiMap doesn't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do the relative / absolute tests with the same data? It's nice to be able to compare the result of each with one another.
close: #469