Add a streaming writer #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all looks good to me. Other than that one conflict in lib.rs, is there anything else needed before merging this? |
|
@fintelia I have rebased on master now. I am reasonably sure that this should be ready for merging. |
|
Thanks! |
|
Thanks @birktj for your work! I have two questions regarding this feature:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a streaming png writer so that you can create images that do not fit in memory. I choose to not update
Writer::write_image_dataas theStreamWriterhas a few layers of buffering that may reduce performance a little bit. I selected a default chunk size of 4k, this number was a bit out of thin air, however there are only a few extra bytes per chunk so I don't think it will be a problem.Fixes #75