Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use suffix _mut? #113

Closed
bvssvni opened this issue Oct 16, 2014 · 4 comments
Closed

Use suffix _mut? #113

bvssvni opened this issue Oct 16, 2014 · 4 comments
Labels
discussion

Comments

@bvssvni
Copy link
Contributor

bvssvni commented Oct 16, 2014

The standard library uses a suffix _mut.

mut_pixelbuf => pixelbuf_mut
mut_rawbuf => rawbuf_mut
@bvssvni bvssvni mentioned this issue Oct 16, 2014
Merged
@bvssvni
Copy link
Contributor Author

bvssvni commented Oct 16, 2014

I do not feel very strongly about either convention, but I think it important to learn from the standard library. Perhaps there is some rationale in the coding style guidelines?

@maxsnew
Copy link
Contributor

maxsnew commented Oct 16, 2014

👍 being consistent with the stdlib naming conventions makes the library easier to learn.

@TyOverby
Copy link
Contributor

👍

@bvssvni bvssvni mentioned this issue Nov 3, 2014
Closed
4 tasks
@bvssvni bvssvni changed the title Use suffix _mut? Use postfix _mut? Nov 3, 2014
@bvssvni bvssvni changed the title Use postfix _mut? Use suffix _mut? Nov 3, 2014
@bvssvni
Copy link
Contributor Author

bvssvni commented Nov 3, 2014

I opened up a new issue #129 and made a PR.

@bvssvni bvssvni closed this as completed Nov 3, 2014
kstrafe pushed a commit to kstrafe/image that referenced this issue Jun 27, 2020
@HeroicKatora
Merge pull request image-rs#113 from danieldulaney/pixel-format-sizes
8bf618a 
Add a method to determine the size in pixels for a given format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TyOverby @maxsnew @bvssvni