Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIF partially broken? #91

Closed
nwin opened this issue Sep 4, 2014 · 10 comments · Fixed by #215
Closed

GIF partially broken? #91

nwin opened this issue Sep 4, 2014 · 10 comments · Fixed by #215

Comments

@nwin
Copy link
Contributor

nwin commented Sep 4, 2014

This sunflower from makes opening.rs fail with index out of bounds. This is maybe related to #63. The quilt design example on the other hand works…

@nwin nwin added the bug label Sep 4, 2014
@nwin nwin added this to the 0.1 milestone Sep 4, 2014
@ccgn ccgn self-assigned this Sep 4, 2014
@ccgn
Copy link
Contributor

ccgn commented Sep 4, 2014

i'll look into it

@bvssvni
Copy link
Contributor

bvssvni commented Oct 27, 2014

Is this fixed?

@nwin
Copy link
Contributor Author

nwin commented Oct 27, 2014

No.

@bvssvni bvssvni removed this from the 0.1 milestone Oct 28, 2014
@bvssvni
Copy link
Contributor

bvssvni commented Oct 28, 2014

From comment #58 (comment)

The bug is in the LZW decoder and the documentation for LZW is really…brief. This is why I didn't do much on TIFF lately because I also ran into problems with it and couldn't figure out how exactly LZW is supposed to work in detail.

@bvssvni
Copy link
Contributor

bvssvni commented Oct 28, 2014

@kanetkarster
Copy link

I've done some rudimentary testing (about 10 images) and it seems this works with gifs encoded with 89a but fails those encoded with 87a

@nwin
Copy link
Contributor Author

nwin commented Nov 16, 2014

Interesting finding. I had a look at the specs. At least until decompression it looks like it should be correct and the same for both standards.

@kanetkarster
Copy link

I'm wondering if it the dependent on the starting location of the actual image data blocks, based off this documentation

@nwin
Copy link
Contributor Author

nwin commented Nov 16, 2014

No this doesn't matter. Until the actual image data it is read correctly. As far as I can see every gif 87a image should be a valid gif 89a image.

@nwin
Copy link
Contributor Author

nwin commented Nov 17, 2014

Maybe there is really something wrong with the reading of the image data blocks. It seems to fail too if the images are too big…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants