Provide bits_per_pixel and num_components as ColorType methods #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that these would make sense. Their exposed interface should simply be inherent methods on |
|
Sorry for the wait for such a small change. |
dobrakmato
changed the title
dobrakmato
changed the title
dobrakmato
changed the title
HeroicKatora
requested changes
Aug 16, 2019
|
@dobrakmato Is there something we can help you with for progressing this PR? |
|
Sorry I am currently on a vacation but I will get to the PR as soon as I
home.
…On Fri, Aug 30, 2019, 05:46 HeroicKatora ***@***.***> wrote:
@dobrakmato <https://github.com/dobrakmato> Is there something we can
help you with for progressing this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1002?email_source=notifications&email_token=AAF6JTNM2SSSHRVCT6WGPYDQHBGUVA5CNFSM4IJFQNV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QBCTI#issuecomment-526389581>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF6JTJJ3RYXV3DGX57NJSDQHBGUVANCNFSM4IJFQNVQ>
.
|
HeroicKatora
approved these changes
Sep 2, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to get
ColorTypeby calling.color()onDynamicImagebutbits_per_pixel()nornum_components()function are available because they are not exported.This PR exports them so they are available to use with
ColorTypestructs returned fromDynamicImage.@nwin, @ccgn @HeroicKatora
I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to chose either at their option.