Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'ff' feature name #2140

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

fintelia
Copy link
Contributor

@fintelia fintelia changed the base branch from master to next-version-0.25 February 12, 2024 04:52
@kornelski
Copy link
Contributor

kornelski commented Feb 12, 2024

The comment helps, but cargo and crates.io don't display it. Non-abbreviated googlable name would be better IMHO.

I see this is meant to consistently follow file extensions, but that doesn't work well with obscure formats. The 3-4 letter namespace is crowded — googling for "ff file format" finds Call Of Duty Fast File and pages mentioning Firefox.

@fintelia fintelia merged commit 2643c75 into image-rs:next-version-0.25 Feb 13, 2024
31 checks passed
@fintelia fintelia deleted the feature-doc branch February 13, 2024 03:17
@fintelia
Copy link
Contributor Author

Yeah, it would be nice if cargo, rustdoc, or crates.io could display feature documentation. But for now, this is a default feature so most people shouldn't need to worry about it, and hopefully anyone who does need to know will look at the Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants