Update all dependencies #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank God this didn't explode.
fosskers
commented
May 10, 2023
Comment on lines
+418
to
+435
| struct BoundedFloat(f64); | ||
|
|
||
| impl Arbitrary for BoundedFloat { | ||
| fn arbitrary(g: &mut Gen) -> Self { | ||
| let mut f; | ||
|
|
||
| loop { | ||
| f = f64::arbitrary(g); | ||
|
|
||
| if f.is_normal() { | ||
| f = f.clamp(-1_000_000.0, 1_000_000.0); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| BoundedFloat(f) | ||
| } | ||
| } |
There was a problem hiding this comment.
With the upgrade to the newest version of quickcheck, certain degenerate Vec<f64> were being generated and passed to test cases, either failing outright or causing strange infinite loops. This BoundedFloat logic ensures that no such degenerate Vecs are generated.
The clamping is probably not as elegant as it could be, but it solves the problem.
|
Hi, any thoughts? |
|
Thanks! |
|
Thanks for the merge! Would it be possible to make a release that includes these bumps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all dependencies to avoid multiple versions of transitive dependencies in downstream users of this crate.