Fix type check that caused empty sources #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CodiumAI-Agent /improve --extended |
Comment on lines
+479
to
483
| if ( ( ! $image_uses_standard_source && $source === '' ) || ( $image_uses_standard_source && $exclude_standard ) ) { | ||
| if ( $image_uses_standard_source && $exclude_standard ) { | ||
| ISC_Log::log( sprintf( 'image %d: "own" sources are excluded', $attachment_id ) ); | ||
| } else { | ||
| ISC_Log::log( sprintf( 'image %d: skipped because of empty source', $attachment_id ) ); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
+647
to
649
| if ( Standard_Source::standard_source_is( 'exclude' ) && $connected_atts[ $_attachment->ID ]['standard'] ) { | ||
| unset( $connected_atts[ $_attachment->ID ] ); | ||
| continue; |
There was a problem hiding this comment.
Suggestion: The variable $_attachment in line 647 is not very descriptive. Consider renaming it to something more meaningful. [best practice]
Suggested change
| if ( Standard_Source::standard_source_is( 'exclude' ) && $connected_atts[ $_attachment->ID ]['standard'] ) { | |
| unset( $connected_atts[ $_attachment->ID ] ); | |
| continue; | |
| if ( Standard_Source::standard_source_is( 'exclude' ) && $connected_atts[ $attachment_id ]['standard'] ) { | |
| unset( $connected_atts[ $attachment_id ] ); | |
| continue; | |
| } |
Comment on lines
+479
to
483
| if ( ( ! $image_uses_standard_source && $source === '' ) || ( $image_uses_standard_source && $exclude_standard ) ) { | ||
| if ( $image_uses_standard_source && $exclude_standard ) { | ||
| ISC_Log::log( sprintf( 'image %d: "own" sources are excluded', $attachment_id ) ); | ||
| } else { | ||
| ISC_Log::log( sprintf( 'image %d: skipped because of empty source', $attachment_id ) ); |
There was a problem hiding this comment.
Suggestion: Simplify the conditional logic in the if statement at line 479. You can combine the two conditions into one by using the logical OR operator (||). [maintainability]
Suggested change
| if ( ( ! $image_uses_standard_source && $source === '' ) || ( $image_uses_standard_source && $exclude_standard ) ) { | |
| if ( $image_uses_standard_source && $exclude_standard ) { | |
| ISC_Log::log( sprintf( 'image %d: "own" sources are excluded', $attachment_id ) ); | |
| } else { | |
| ISC_Log::log( sprintf( 'image %d: skipped because of empty source', $attachment_id ) ); | |
| if ( ! $image_uses_standard_source && $source === '' || $image_uses_standard_source && $exclude_standard ) { | |
| if ( $image_uses_standard_source && $exclude_standard ) { | |
| ISC_Log::log( sprintf( 'image %d: "own" sources are excluded', $attachment_id ) ); | |
| } else { | |
| ISC_Log::log( sprintf( 'image %d: skipped because of empty source', $attachment_id ) ); | |
| } | |
| } |
… if the option to exclude standard sources from sources lists was selected.
webzunft
force-pushed
the
fix-standard-source-check
branch
from
9df6a4b
to
d157e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combination of a hardened type check, image sources did not show up if the option to exclude standard sources from sources lists was selected.