detect linux-aarch6 correctly for ffmpeg filenames #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is great! Could you please move the import to the top of the module please? |
|
I also wanted to update the Contribution guidelines (to include how to test). Maybe I can do a follow up PR. Unless you're not interested; let me know. |
That'd be great. Yeah lets do in a new pr 👍 |
|
Pypy build is hanging, but this is likely unrelated to this pr, so I'll merge! |
almarklein
changed the title
almarklein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying to run moviepy in a docker container (Docker for Mac on M1). I got the error:
RuntimeError: No ffmpeg exe could be found. Install ffmpeg on your system, or set the IMAGEIO_FFMPEG_EXE environment variable.Digging into the source of the issue, it was detecting the platform as
linux64instead oflinuxaarch64. manually patching this on my machine fixed it, so I thought I would upstream it.I think it'll resolve #71