FEAT: add is_batch kwarg to pillow #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be RTR. I will keep the same procedure as last week until @almarklein comes back from vacation. I will leave the PR unmerged for anyone to review and if there are no open discussion points by Friday, I will merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new kwarg to
PillowPlugin.writecalledis_batch. Currently, we try to figure out if the passed ndarray is an image or an image batch by looking at the shape or mode. This isn't always correct due to the aliasing of shapes, e.g., a(5, 5, 3)image could be a 5x5 RGB image or a batch of 5 5x3 grayscale images.This PR hence adds
is_batchas an optional kwarg to allow the user to explicitly pass this information if relevant.