TEST: Flag missing tests that require internet connection #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirefoxMetzger
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Thanks for the PR and well spotted @olebole 🚀
(Also sorry for the late review. I've been on vacation in China and didn't have access to GH.)
|
Note that CI will fail because an upstream dependency (pillow) released a new major version, which breaks one of our tests. This is unrelated to this PR and there already is a PR to address this. Once that PR's CI is green I will merge and update this PR. |
FirefoxMetzger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently working on the update of the imageio package for Debian. Debian requires that no internet resources are used during the build (which includes a test of the package).
Here I found a few test cases that require internet access but were not marked as such. This PR fixes them.