Support HEIF image file #1042
Support HEIF image file #1042
Conversation
|
never mind about my previous deleted comment. as I see, CI needs wheels for PyPy3.8 - if I will know that this will have high chances to be merged, I can restore the publishing of PyPy3.8 wheels for the next release, if it is needed. |
There was a problem hiding this comment.
Awesome initiative, thanks @Pandede 🚀 This looks pretty good from the plugin implementation side. I think we'll only need one round of reviews before we can merge.
We should properly register the format so that pillow is automatically tried first for .heic files. To do so we need to add a new FileExtension in the relevant config file. This will also add the necessary documentation so that HEIC shows up in the list of supported formats :)
Beyond that, there is one change (making pillow_heif option) that I would like to see before we merge.
done from my side, new release was published :) |
|
The tests are failed as the latest upgrade of Update: # Raise AttributeError
image = Image.open("example.png", mode="L")
# Should specify the mode by using `convert`
image = Image.open("example.png").convert("L")Here is the reference. |
|
Yes. There is another issue related to pillow's recent upgrade. I'll pin pillow for now. |
| @@ -1855,6 +1855,9 @@ def reset(self): | |||
| extension=".btf", | |||
| priority=["tifffile"], | |||
| ), | |||
| FileExtension( | |||
| name="High Efficiency Image File Format", extension=".heic", priority=["pillow"] | |||
There was a problem hiding this comment.
Shoudn't ".heif" and ".hif" (and potentially ".avif") be added as well?
There was a problem hiding this comment.
Yes. Some cameras now output .HIF directly (I guess limitations of sdcard filesystem like old 8.3 filename format from DOS times!)
There was a problem hiding this comment.
2.33.0 is still missing ".heif" and ".hif".
Also, libheif from 1.17 supports the JPEG 2000 codec inside the HEIF container w/ a ".hej2" extension, see https://www.itu.int/rec/T-REC-T.815/en
There was a problem hiding this comment.
Maybe create a new issue about the multiple extensions of HEIF?
Resolves #1021.
The previous pull request #1040 is closed as the redundant commits.
And also, move
pillow-heifto be a plugin rather than extra requirement ofPillow(thanks for the advice of @bigcat88).