Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update actions/checkout and actions/setup-python #1085

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

boidolr
Copy link
Contributor

@boidolr boidolr commented May 20, 2024

The current versions will run on soon to be unsupported versions of Node
(see https://github.blog/changelog/2024-05-17-updated-dates-for-actions-runner-using-node20-instead-of-node16-by-default/).

The current versions will run on soon to be unsupported
versions of Node.
Copy link
Contributor

@FirefoxMetzger FirefoxMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very good thing to do. Thanks for the PR 🚀

@boidolr
Copy link
Contributor Author

boidolr commented May 30, 2024

Not sure why the hash for requirements on macOS fails - I don't think it is related to the update of the workflow actions though, especially considering other platforms working without issues. Let me know what I can do to resolve this, if at all.

@FirefoxMetzger
Copy link
Contributor

@boidolr no it's not related. It's because Pypi 3.8 is phasing out ... I was hoping to remove it from our tests alongside the tests for cpython 3.8 (which will reach EoL after summer). However, this is breaking quite regularly now, so I will just remove it now instead.

@FirefoxMetzger
Copy link
Contributor

Fixed one error, found the next. I also don't think this one is related to your PR. It looks like our ffmpeg plugin is not loading the ffmpeg binary correctly anymore - i need to investigate.

@FirefoxMetzger FirefoxMetzger merged commit a4f4c05 into imageio:master Jun 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants