Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: seeking to last frame caused EoF in pyav #855

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

FirefoxMetzger
Copy link
Contributor

I noticed a bug in pyav that would cause a EoF exception when you try to read only the last frame of the image, e.g. something like

import imageio.v3 as iio

props = iio.improps("imageio:cockatoo.mp4", plugin="pyav")
frame = iio.imread("imageio:cockatoo.mp4", index=props.shape[0]-1, plugin="pyav")

This was caused be me getting the decoder after seeking via container.decode instead of reusing the decoder I used for seeking. I thought the object was shared, but apparently it is not ... this PR fixes that.

@FirefoxMetzger FirefoxMetzger merged commit 7ff7f02 into imageio:master Aug 6, 2022
@FirefoxMetzger FirefoxMetzger deleted the seek-bug-pyav branch August 6, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant