Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IJ1's overlays #8

Closed
ctrueden opened this issue May 18, 2014 · 2 comments
Closed

Support IJ1's overlays #8

ctrueden opened this issue May 18, 2014 · 2 comments
Labels
enhancement
Milestone
m2

Comments

@ctrueden
Copy link
Member

Currently IJ2 translates IJ1 ROIs to IJ2 Overlays and vice versa. We are doing nothing to handle IJ1 Overlays. We should have a flag associated with each IJ1 Roi saying whether it is a ROI or an Overlay. Then translations can respect this distinction.

Note that right now overlays are repeatedly recreated in the harmonizer. We need to track individual IJ1 Roi/Overlay to IJ2 Overlay mappings.

Note that as of beta 6 the current IJ2 Overlay goes across legacy layer as the ImagePlus' Roi and the other IJ2 Overlays go as a set of Rois in the Overlay of the ImagePlus.

Migrated-From: http://trac.imagej.net/ticket/1308
@dscho
Copy link
Contributor

dscho commented May 26, 2014

I am afraid that this is post June 1st.

@hinerm hinerm added this to the m2 milestone Mar 23, 2015
@hinerm hinerm self-assigned this Mar 23, 2015
@ctrueden
Copy link
Member Author

ctrueden commented Nov 7, 2018

With @awalter17's work on IJ1<->ImgLib2 ROI converters (#183), this issue is finally addressed! 🎉

@ctrueden ctrueden closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
m2
Development

No branches or pull requests
3 participants
@dscho @ctrueden @hinerm